Optimizing Oengus schedule Import#129
Open
gaeldemarseille wants to merge 1 commit intospeedcontrol:masterfrom
Open
Optimizing Oengus schedule Import#129gaeldemarseille wants to merge 1 commit intospeedcontrol:masterfrom
gaeldemarseille wants to merge 1 commit intospeedcontrol:masterfrom
Conversation
- calling twitch and speedrun.com api asynchronously - removed the 1s sleep from searchForUserData - prevent speedrun.com api rate limiting - no longer call speedrun.com api for runners info if we won't use any of them - added caching to searchForTwitchGame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import duration difference from
[Oengus Import] Started importing scheduleto[Oengus Import] Successfully imported schedule from Oengus:Old code
New Code