Try out github.com/christophebedard/dco-check#5010
Merged
azdagron merged 4 commits intospiffe:mainfrom Mar 28, 2024
Merged
Conversation
The DCO app currently used in the repository doesn't support GitHub merge queues. Try out this other DCO check script which will run as our own managed job that we can configure to run for PRs added to the merge queue. We can try running this check in parallel to the existing check to ensure it's stable before trying to rely on it. Signed-off-by: Ryan Turner <turner@uber.com>
rturner3
requested review from
MarcosDY,
amartinezfayo,
azdagron and
evan2645
as code owners
added 2 commits
March 22, 2024 13:03
Signed-off-by: Ryan Turner <turner@uber.com>
Signed-off-by: Ryan Turner <turner@uber.com>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
* Try out github.com/christophebedard/dco-check The DCO app currently used in the repository doesn't support GitHub merge queues. Try out this other DCO check script which will run as our own managed job that we can configure to run for PRs added to the merge queue. We can try running this check in parallel to the existing check to ensure it's stable before trying to rely on it. Signed-off-by: Ryan Turner <turner@uber.com> * Fix YAML syntax Signed-off-by: Ryan Turner <turner@uber.com> * Allow to run on workflow_dispatch Signed-off-by: Ryan Turner <turner@uber.com> --------- Signed-off-by: Ryan Turner <turner@uber.com> Co-authored-by: Andrew Harding <azdagron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DCO app currently used in the repository doesn't support GitHub merge queues. Try out this other DCO check script which will run as our own managed job that we can configure to run for PRs added to the merge queue.
We can try running this check in parallel to the existing check to ensure it's stable before trying to rely on it.
Tested on my fork with a couple sample PRs targeted towards this branch:
Success on DCO present: rturner3#218
Fail on missing DCO: rturner3#216