merge wasip2 branch into main#44

Merged

dicej merged 34 commits intospinframework:mainfrom

Mar 27, 2026

Collaborator

dicej commented Mar 24, 2026

The branch has been hanging out for a while and seems ripe enough to merge.

rajatjindal and others added 24 commits

November 10, 2024 14:15


          feat(sdk): add support for http trigger with wasip2 support

d7c7c4f

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>


          Merge pull request spinframework#8 from rajatjindal/wasip2-http

383ffc5

[wasip2] incoming http handler


          update go-modules and cm package. regen bindings

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>


          Merge pull request spinframework#16 from rajatjindal/switch-org

6c3e074

update go-modules and cm package. regen bindings


          feat(wasip2/kv): add support for wasip2 kv

3cd22af

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>


          install wasm-tools and v3.2.0 of spin

5b03b6d

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>


          Merge pull request spinframework#17 from rajatjindal/spin-w2-kv

9f90e21

feat(wasip2/kv): add support for wasip2 kv


          feat(wasip2/llm): add support for llm

8c008a4

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>


          Merge pull request spinframework#18 from rajatjindal/spin-w2-llm

3b8bb70

add llm support for wasip2 sdk


          add variables support for wasip2 sdk

72c0f22

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>


          Merge pull request spinframework#19 from rajatjindal/spin-w2-variables

8ffe6d3

Add support for wasip2 variables


          Move v2 to v3

df221c7

Signed-off-by: Adam Reese <adam@reese.io>


          Merge pull request spinframework#23 from adamreese/ref/wasip2-v3

a65f13a

Move wasip2 sdk to v3 directory


          feat(mqtt): implement mqtt in wasip2

ea81e64

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>


          Merge pull request spinframework#32 from asteurer/wasip2-mqtt

1a3e34e

feat(mqtt): implement mqtt in wasip2


          feat(redis): implement redis in wasip2

52313d0

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>


          Merge pull request spinframework#35 from asteurer/wasip2-redis

aaeb45a

feat(redis): implement redis in wasip2


          feat(mysql): implement mysql in wasip2

b616203

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>


          Merge pull request spinframework#31 from asteurer/wasip2-mysql

a52a86a

feat(mysql): implementing mysql in wasip2


          feat(wasip2): regenerate bindings with componentize-go

f407c8f

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>


          Merge pull request spinframework#40 from asteurer/migrate-wasip2

51d5378

Migrate `wasip2` branch to use the new WIT bindings generator


          fix: update componentize-go endpoint

af71a11

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>


          Merge pull request spinframework#43 from asteurer/migrate-wasip2

b8cb553

fix: update componentize-go endpoint


          Merge remote-tracking branch 'origin/main' into wasip2

12995fb

dicej requested a review from adamreese

March 24, 2026 22:14

dicej force-pushed the wasip2 branch from e835490 to 760424f Compare

March 24, 2026 22:35


          revert mysql.go changes which caused test regression

d172d4b

Signed-off-by: Joel Dice <joel.dice@akamai.com>

dicej force-pushed the wasip2 branch from 760424f to d172d4b Compare

March 24, 2026 22:36


          move v3 into root, fix broken stuff, etc.

593ea45

- move v3/* into the root of the repo
- update the v2 packages (e.g. `sqlite`, `pg-outbound`, etc.) to v3
- remove obsolete C-based binding generation
- fix broken tests and examples

Signed-off-by: Joel Dice <joel.dice@akamai.com>

dicej force-pushed the wasip2 branch from 830355e to 593ea45 Compare

March 25, 2026 18:30


          remove unused file

419156b

Signed-off-by: Joel Dice <joel.dice@akamai.com>

Contributor

adamreese commented Mar 25, 2026

I'm not sure what the directory for /redis_internal is. Should the contents be in /internal?

Collaborator Author

dicej commented Mar 25, 2026 •

edited

Loading

I'm not sure what the directory for /redis_internal is. Should the contents be in /internal?

One is for targeting the fermyon:spin/redis-trigger world, while the other is for targeting the fermyon:spin@3.0.0/http-trigger world. I tried combining them, but that caused redis trigger apps to import wasi:http@0.2.0 interfaces which aren't included in the redis-trigger world and which Spin won't provide for inbound redis components.

I'm open to other approaches, but I can't think of any that will work short of updating Spin to allow inbound redis components to import all the same things inbound http components can.

Contributor

adamreese commented Mar 25, 2026

We could change /redis_internal/ to /inbound_redis/internal/ to prevent it from being exported. internal is a special directory name for private packages.

Collaborator Author

dicej commented Mar 25, 2026

We could change /redis_internal/ to /inbound_redis/internal/ to prevent it from being exported. internal is a special directory name for private packages.

Ah, good to know. I'll give that a try, thanks.


          move redis_internal to inbound_redis/internal

d881ce5

Signed-off-by: Joel Dice <joel.dice@akamai.com>

adamreese reviewed

View reviewed changes

examples/redis-outbound/main.go Outdated

examples/mysql-outbound/main.go

+              			return
+              		}
+              		if _, err := db.Exec("INSERT INTO pets VALUES (?, ?, ?, ?)", 5, "Copper", "Foxes", false); err != nil {

Contributor

adamreese Mar 25, 2026

Welcome Copper!

http/http.go

+              	// convert the incoming request to go's net/http type
+              	httpReq, err := NewHttpRequest(*request)
+              	if err != nil {
+              		//TODO(rajatjindal): return internal error from here

Contributor

adamreese Mar 25, 2026

@rajatjindal Does this TODO need to be addressed before merging to main?

Collaborator Author

dicej Mar 26, 2026

FWIW, Spin will automatically return a 500 error when the handler returns without sending a response to responseOut first, so this doesn't seem particularly urgent to me.

dicej mentioned this pull request

Async Redis trigger spinframework/spin#3435

Merged

dicej force-pushed the wasip2 branch 2 times, most recently from b62d43f to d2cc91f Compare

March 25, 2026 23:50

Collaborator Author

dicej commented Mar 26, 2026

Per bytecodealliance/componentize-go#35 and the ensuing conversation, I'm planning to tweak how componentize-go is used a bit more tomorrow so we don't have to pass as many flags to it.

adamreese reviewed

View reviewed changes

examples/variables/go.mod Outdated

examples/variables/spin.toml Outdated

http/testdata/http/main.go Outdated

dicej force-pushed the wasip2 branch from e37581e to 840094e Compare

March 26, 2026 17:11

adamreese approved these changes

View reviewed changes

Member

radu-matei commented Mar 27, 2026

Running spin build in one of the examples:
(componentize-go installed right before this):

spin b
Building component hello with `componentize-go build`
Error: failed to read path for WIT [wit]

Caused by:
    No such file or directory (os error 2)
Error: Build command for component hello failed with status Exited(1)

Contributor

adamreese commented Mar 27, 2026

@radu-matei This is dependent on bytecodealliance/componentize-go#35

cargo install --locked --git https://github.com/dicej/componentize-go --rev fad2c00f

dicej force-pushed the wasip2 branch from c91cd0c to 2281f09 Compare

March 27, 2026 15:30

Contributor

adamreese commented Mar 27, 2026

@dicej We should add a note to the README about installing componentize-go with the rev

dicej added 4 commits

March 27, 2026 09:34


          s/tinygo/Go/ in redis-outbound example

4e50c99

Signed-off-by: Joel Dice <joel.dice@akamai.com>


          update componentize-go and make use of new features

e4867dc

Per bytecodealliance/componentize-go#35, Spin
applications can now refer to WIT files by way of the
`github.com/spinframework/spin-go-sdk/v3` source package; no need for the
application to supply them itself.

That PR also allows us to pass multiple `--world` flags to `componentize-go`,
allowing us to target e.g. the `fermyon:spin/redis-trigger` _and_
`spin:up/platform` worlds at the same time (which is what Spin actually
implements for Redis triggers).

Signed-off-by: Joel Dice <joel.dice@akamai.com>


          upgrade componentize-go again to further simplify examples and tests

5b1210e

Signed-off-by: Joel Dice <joel.dice@akamai.com>


          remove unnecessary WriteHeader statements

65425aa

Signed-off-by: Joel Dice <joel.dice@akamai.com>

dicej force-pushed the wasip2 branch from 2281f09 to 65425aa Compare

March 27, 2026 15:34


          add note to readme about temporary componentize-go fork

aca9fe2

Signed-off-by: Joel Dice <joel.dice@akamai.com>

dicej merged commit b727e58 into spinframework:main

2 checks passed

dicej deleted the wasip2 branch

March 27, 2026 15:53

This was referenced Mar 27, 2026

Implement Redis inbound for WASIP2 #39

Closed

Implement Postgres for WASIP2 #28

Closed

Implement Sqlite for WASIP2 #27

Closed

Update SDK to support WASIP2 #13

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet