fix(jenkins): fix the issue of Retrofit2EncodeCorrectionInterceptor getting added to Jenkins retrofit1 client

[kirangodishala]

• This PR addresses the issue - Triggering a Jenkins job with parameters replace spaces with + spinnaker#7059
• The OkHttpClient autowired in JenkinsConfig was coming from RawOkHttpClientConfiguration which is adding the interceptors meant for retrofit2 client. This PR takes care of the issue by getting the OkHttpClient from the right source which is OkHttp3ClientConfiguration.
• Added a test to demonstrate the issue of Retrofit2EncodeCorrectionInterceptor getting added to the Jenkins retrofit1 client.

[dbyron-sf]

Is RawOkHttpClientConfiguration still required after the fix?

[kirangodishala]

It's not needed but it shows the real scenario of two OkHttpClient beans available but JenkinsConfig is using the right one. Let me know if you want me remove it.

[dbyron-sf]

Hmmm...this is a tough one. Aren't we getting lucky here? RawOkHttpClientConfiguration uses @ConditionalOnMissingBean. What guarantees do we have that JenkinsConfig doesn't pick that up?

[kirangodishala]

Removed RawOkHttpClientConfiguration and converted the test to java.

[dbyron-sf]

Great. What about @ConditionalOnMissingBean though? Aren't we still getting lucky in the main igor code, because Main has:

@SpringBootApplication(
  scanBasePackages = [
    "",
    "com.netflix.spinnaker.igor"
  ],
  exclude = [GroovyTemplateAutoConfiguration]
)

and specifically com.netflix.spinnaker.config because RawOkHttpClientConfiguration is in

package com.netflix.spinnaker.config.okhttp3;

[dbyron-sf]

If RawOkHttpClientConfiguration gets processed first, I guess we end up with two OkHttpClient beans, one named okhttp3Client (from RawOkHttpClientConfiguration) and one named okHttpClient (from JenkinsConfig). And since the rest of the code in JenkinsConfig uses the variable name okHttpClient (and not okhttp3Client) perhaps things "just work." We're gonna go ahead ...