fix(cuda): initialize AL vertex-half-plane TOI buffer after resize#409
Merged
MuGdxy merged 1 commit intospiriMirror:mainfrom Mar 28, 2026
Merged
fix(cuda): initialize AL vertex-half-plane TOI buffer after resize#409MuGdxy merged 1 commit intospiriMirror:mainfrom
MuGdxy merged 1 commit intospiriMirror:mainfrom
Conversation
The tois buffer was resized but not initialized, leaving stale values that could cause incorrect TOI filtering in AL-IPC half-plane contact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds an initialization step for the tois buffer in the CUDA collision detection trajectory filter. The review feedback suggests improving code maintainability by replacing the magic number 1.1f with a named constant and optimizing the buffer initialization by using a combined resize and fill operation if supported by the API.
src/backends/cuda/collision_detection/filters/al_vertex_half_plane_trajectory_filter.cu
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toisbuffer with1.1fafterresize()inALVertexHalfPlaneTrajectoryFilter::filter_toi()to prevent uninitialized values (skipped by contact tabular check) from affecting TOI filtering in AL-IPC half-plane contactTest plan
🤖 Generated with Claude Code