Fix NaN faces and vertices with latest three.js#25
Open
benjaminleonard wants to merge 1 commit intospite:masterfrom
benjaminleonard:nan-faces
Open
Fix NaN faces and vertices with latest three.js#25benjaminleonard wants to merge 1 commit intospite:masterfrom benjaminleonard:nan-faces
benjaminleonard wants to merge 1 commit intospite:masterfrom
benjaminleonard:nan-faces
Conversation
Also switching some deprecated parts so the example works with three.js r93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per: aframevr/aframe#3616
Also switching some deprecated parts so the example works with three.js r93
There seems to be a slight issue with the way the sprites render on the new version – not sure if you know why that is?
Vertices have been removed since they're no longer provided by three.js.