Conversation
Member
|
My biggest issue with this is it doesn't let the gateway node know what users are blocked by what nodes. For example let's say the top 5 nodes block X user. Jobs from that user would typically go to those top 5 nodes first, but the gateway doesn't know those 5 nodes blocked that user. Thus, there is no way the gateway can reallocate those jobs to other nodes and get those videos encoded. If you can add that into the PR I'd feel much more comfortable about releasing something like this. |
vaultec81
added
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #19