Perpetual WIP PR to easily allow running github workflows#46
Draft
ndim wants to merge 5 commits intospkr-beep:masterfrom
Draft
Perpetual WIP PR to easily allow running github workflows#46ndim wants to merge 5 commits intospkr-beep:masterfrom
ndim wants to merge 5 commits intospkr-beep:masterfrom
Conversation
Allow defining compile flags per build target. This makes object file names longer, which requires a slight reformat of the silent build rule output and shortening the name issue-6-benchmark to still both align and fit inside an 80 column terminal without line wrapping.
The word "note" is more specific than "parms", and we have been using the word note in the comments already.
ndim
force-pushed
the
wip
branch
2 times, most recently
from
d3eec26 to
a01cafc
Compare
Log all pcspkr tone events (begin tone, begin pause) to special log file with 0.02s resolution. The log file must be opened by the caller and the file descriptor passed to beep via the BEEP_PCSPKR_LOGFD environment variable. This log file allows automated verification of the event sequences which result from a given command line. That should be helpful for ensuring main loop rewrites do not change the resulting beep pattern.
This removes the unnecessary duplicate "silence the PC speaker" command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the perpetual WIP PR to easily allow running github workflows.