Skip to content

Update constructor to accept nullable Colors parameter #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Update constructor to accept nullable Colors parameter #37

merged 1 commit into from
Oct 28, 2025

Conversation

@SMillerDev
Copy link
Contributor

This will resolve issues in PHP 8.4 like the following

PHP Deprecated:  splitbrain\phpcli\Options::__construct(): Implicitly marking parameter $colors as nullable is deprecated, the explicit nullable type must be used instead in phpdraft/vendor/splitbrain/php-cli/src/Options.php on line 43

@splitbrain splitbrain merged commit 813410b into splitbrain:master Oct 28, 2025
8 checks passed
@SMillerDev
Copy link
Contributor Author

Thanks for merging it so quickly. I found a couple more after this so I'll make a PR for those later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SMillerDev @splitbrain