This repository was archived by the owner on May 10, 2018. It is now read-only.
fix for https://github.com/splunk/splunk-sdk-ruby/issues/28#44
Open
fornellas wants to merge 1 commit intosplunk:masterfrom
Open
fix for https://github.com/splunk/splunk-sdk-ruby/issues/28#44fornellas wants to merge 1 commit intosplunk:masterfrom
fornellas wants to merge 1 commit intosplunk:masterfrom
Conversation
Contributor
|
Hi @fornellas, Thanks for doing this work, and submitting the contributor agreement! |
Author
|
Did you review the code? Would this be the best solution? If so, I'll try to write some tests. |
Contributor
|
@fornellas The changes look reasonable, tests would be even better! We won't merge directly into the master branch though, so you will need to make a new PR. |
Contributor
|
@fornellas thanks for submitting this. Would you mind:
|
|
Any progress on this? |
Author
|
I have not had time to learn Test::Unit and build a proper test, I solved my issue here by monkey patching the solution in my application code for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should raise exceptions when error / fatal messages are sent by the API.