chore(m5): cut connector main IPC + preload + agent prompt#113
Merged
chore(m5): cut connector main IPC + preload + agent prompt#113
Conversation
PR2 of M5. Strips the connector subsystem from the Electron main
process, the preload bridge, and the agent search prompt.
main/index.ts:
- Remove ConnectorRegistry / SyncScheduler / TrustStore /
PrerequisiteChecker globals and their init block, the proxy fetch
for connector capabilities, the focus → recheck-prereqs loop, the
powerMonitor 'resume' onWake, and the before-quit syncScheduler.stop()
- Remove the spool:// deep-link parser + dialog handler (open-url + the
spool:// branch in second-instance)
- Remove all 18 connector:* IPC handlers + their helpers
(installConnectorPackage, reloadConnectors, runConnectorUpdateCheck,
getInstalledConnectorPackages, pkgIdForConnector, resolveCliPrereq,
withConnectorLock, makePrerequisitesFor, etc.)
- Narrow spool:search and spool:search-preview to fragments-only;
drop searchAll / searchCaptures from imports
- Drop the now-dead installE2ETestHooks (its only caller was deleted in PR1)
- Drop unused Notification / shell electron imports + node:os, node:fs,
node:child_process, node:path resolve
preload/index.ts:
- Delete the connectors namespace (20+ methods)
- Drop ConnectorStatus / AuthStatus / SchedulerStatus / RegistryConnector
type imports
- Narrow getStarredUuids return type to { session: string[] }
acp.ts:
- Strip the connector captures schema + example queries from the
agent search prompt; agent now only knows about sessions/messages
Deleted:
- packages/app/src/main/dev-connectors.ts + dev-connectors.test.ts
- packages/app/e2e/helpers/seed.ts (only consumer was the e2e test
removed in PR1)
Net: -1185 / +28. main bundle drops from 122.91 kB → 56.65 kB; loader
chunk drops from 610.30 kB → 308.57 kB.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The previous commit replaced searchAll() with searchFragments() in the
spool:search handler. searchFragments returns FragmentResult without a
discriminator; searchAll's wrapper added { kind: 'fragment' as const }
before returning. The renderer narrows results with r.kind === 'fragment'
and was dropping every row, so e2e search tests saw zero matches.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
graydawnc
changed the title
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #112. Strips the connector subsystem from the Electron main process, the preload bridge, and the agent search prompt. The renderer surface was already removed in #112; this PR cuts the IPC + framework wiring behind it. Captures table + connector core code stay until a later PR (DB migration + queries refactor).
main/index.ts
ConnectorRegistry/SyncScheduler/TrustStore/PrerequisiteCheckerglobals + init block, the proxyfetchfor connector capabilities, the focus → recheck-prereqs loop, thepowerMonitorresume→onWake, and thebefore-quitsyncScheduler.stop()spool://connector/install/...deep-link parser + dialog (open-urlhandler + thespool://branch insecond-instance)connector:*IPC handlers + their helpers (installConnectorPackage,reloadConnectors,runConnectorUpdateCheck,getInstalledConnectorPackages,pkgIdForConnector,resolveCliPrereq,withConnectorLock,makePrerequisitesFor, etc.)spool:searchandspool:search-previewto fragments-only; dropsearchAll/searchCapturesfrom core importsinstallE2ETestHooks(its only caller was removed in chore(m5): cut connector UI from renderer (PR1 of 7) #112)Notification/shellelectron imports +node:os/node:fs/node:child_process/path.resolvepreload/index.ts
connectorsnamespace (20+ methods)ConnectorStatus/AuthStatus/SchedulerStatus/RegistryConnectortype importsgetStarredUuidsreturn type to{ session: string[] }acp.ts
sessions/messagesDeleted
packages/app/src/main/dev-connectors.ts+dev-connectors.test.tspackages/app/e2e/helpers/seed.ts(its only consumer was the e2e test removed in chore(m5): cut connector UI from renderer (PR1 of 7) #112)-1185 / +28net.main/index.tsshrinks from 1146 → 432 lines.Bundle size impact (electron-vite):
out/main/index.js: 122.91 kB → 56.65 kBout/main/chunks/loader-*.js: 610.30 kB → 308.57 kBTest plan
pnpm exec tsc --noEmitcleanpnpm build:electronpasses (core + connector-sdk + main + preload + renderer all rebuild)spool://connector/install/...URLs are now silently ignored (deep-link handler removed)🤖 Generated with Claude Code