chore(npm): clean dist before tsc; bump cli + core to 0.4.1#120
Merged
chore(npm): clean dist before tsc; bump cli + core to 0.4.1#120
Conversation
The 0.4.0 npm publish shipped stale dist artifacts (commands/connector.js and connector-shared.js from before #114 deleted them, plus core's connectors/ subtree from before #115). tsc only writes new files; it does not delete outputs whose source has been removed. The published tarballs were functional (the CLI entry doesn't import the orphans) but ~37 kB heavier than they should be. Fix: prepend `pnpm run clean` (already defined as `rm -rf dist`) to the build script so every fresh build starts from an empty dist/. Verified locally — cli dist now contains only the 5 surviving commands and core dist no longer carries a connectors/ tree. Bump cli + core to 0.4.1 so the clean build can be published. App, landing, and root version stay at 0.4.0 — the Electron release on GitHub is unaffected by this fix and we don't need to cut another DMG just for npm hygiene. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.4.0 npm publish shipped stale dist artifacts (
commands/connector.js+connector-shared.jsin cli, the entireconnectors/subtree in core). tsc only writes new files — it doesn't delete outputs whose source has been removed.Functional impact: none (the CLI entry doesn't import the orphans, so they never execute), but the npm tarballs are ~37 kB heavier than they should be and the situation is misleading.
Fix
pnpm run clean(already defined asrm -rf distin both packages) to thebuildscript. Every fresh build now starts from an emptydist/.@spool-lab/cliand@spool-lab/coreto0.4.1so the clean build can be published. App / landing / root stay at0.4.0; the Electron release on GitHub is unaffected by this fix and there's no reason to cut another DMG just for npm hygiene.Verified locally
pnpm --filter @spool-lab/core build→dist/no longer contains aconnectors/subtreepnpm --filter @spool-lab/cli build→dist/commands/contains onlylist / search / show / status / sync(noconnector*)pnpm install --frozen-lockfilecleanTest plan
pnpm publish -r --no-git-checksto ship the clean 0.4.1