Merged
Conversation
9325431 to
e4a05b6
Compare
pnezis
reviewed
Mar 31, 2025
|
|
||
| expected = | ||
| """ | ||
| * `--var...` (`atom`) - a var [default: `foo, bar`] |
Member
There was a problem hiding this comment.
Isn't better to just inspect the default? It would look like:
Suggested change
| * `--var...` (`atom`) - a var [default: `foo, bar`] | |
| * `--var...` (`atom`) - a var [default: `[:foo, :bar]`] |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
that's the test tho, the normal doc would look ok?
Member
There was a problem hiding this comment.
Exactly this is the escaped string, mix help, and mix docs will look fine
Contributor
Author
There was a problem hiding this comment.
did you mean to do inspect only when default is list or not?
Member
There was a problem hiding this comment.
we can always inspect, #{inspect(...)}
e4a05b6 to
945505e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.