feat: js local resolver #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
19
to
21
| clientKey:string, | ||
| clientId:string, | ||
| clientSecret:string, |
There was a problem hiding this comment.
Suggested change
| clientKey:string, | |
| clientId:string, | |
| clientSecret:string, | |
| flagClientSecret:string, | |
| apiClientId:string, | |
| apiClientSecret:string, |
openfeature-provider/js/src/lease.ts
Outdated
|
|
||
| export type CachedProvider<T> = () => Promise<T> | ||
|
|
||
| export function leaseFactory<T>(renewer:() => Promise<Lease<T>>, marginMs = 5000):CachedProvider<T> { |
There was a problem hiding this comment.
Do a background update before lease expires. Handle errors with retries.
openfeature-provider/js/src/lease.ts
Outdated
| let current:Lease<T> | null = null; | ||
| return async () => { | ||
| if(!current || isExpired(current)) { | ||
| const [value, expiry] = await renewer(); |
There was a problem hiding this comment.
If renewer fails we MUST AT LEAST clear current value.
| status: ProviderStatus = ProviderStatus.NOT_READY; | ||
|
|
||
| private tokenProvider:CachedProvider<string>; | ||
| private stateUriProvider:CachedProvider<{ signedUri:string, account:string }>; |
There was a problem hiding this comment.
Skip caching of uri!
| import { CachedProvider, Lease, leaseFactory } from './lease'; | ||
| import { ResolveReason } from './proto/api'; | ||
|
|
||
| const DEFAULT_STATE_INTERVAL = 10_000; |
There was a problem hiding this comment.
Suggested change
| const DEFAULT_STATE_INTERVAL = 10_000; | |
| const DEFAULT_STATE_INTERVAL = 30_000; |
| return key in obj; | ||
| } | ||
|
|
||
| function valueMatchesSchema<T>(value:unknown, schema:T): value is T { |
There was a problem hiding this comment.
Rename to something with assignsTo.
Comment on lines
2
to
5
| declare module "*.wasm" { | ||
| const content: string; | ||
| export default content; | ||
| } |
Comment on lines
+52
to
+63
| // private transferResponseSuccess<T>(value: T, codec: Codec<T>): number { | ||
| // const data = codec.encode(value).finish(); | ||
| // return this.transfer({ data }, Response); | ||
| // } | ||
| // private transferResponseError<T>(error: string): number { | ||
| // return this.transfer({ error }, Response); | ||
| // } | ||
|
|
||
| // private consumeRequest<T>(ptr: number, codec: Codec<T>): T { | ||
| // const req: Request = this.consume(ptr, Request); | ||
| // return codec.decode(req.data); | ||
| // } |
| @@ -0,0 +1 @@ | |||
| # js | |||
There was a problem hiding this comment.
Ask AI to fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.