Fixes way how ContentItemCell is checked of not being reused.#85
Open
valeriyvan wants to merge 1 commit intospotify:masterfrom
valeriyvan:refactor
Open
Fixes way how ContentItemCell is checked of not being reused.#85valeriyvan wants to merge 1 commit intospotify:masterfrom valeriyvan:refactor
valeriyvan wants to merge 1 commit intospotify:masterfrom
valeriyvan:refactor
Conversation
Check of title for match as way to ensure cell wasn't reused is bad because there's no guaranty titles are unique. UIKit gives method for such check. If UICollectionView.cellForItem(at:) returns not nil - that is exactly cell which is needed. And returns nil if cell is not visible and there's no reason to update it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check of title for match as way to ensure cell wasn't reused is bad because there's no guaranty titles are unique.
UIKit gives method for such check.
If UICollectionView.cellForItem(at:) returns not nil - that is exactly cell which is needed. And returns nil if cell is not visible and there's no reason to update it.