Skip to content
This repository was archived by the owner on Jul 15, 2019. It is now read-only.

adding merge_config support#2

Open
fooelisa wants to merge 20 commits intospotify:masterfrom
fooelisa:master
Open

adding merge_config support#2
fooelisa wants to merge 20 commits intospotify:masterfrom
fooelisa:master

Conversation

@fooelisa
Copy link

Noteworthy pyEOS/eos.py changes:

re-naming of compare_config based on napalm/issue/4:

  • def compare_config(self):
  • def compare_replace_config(self):

adding:

  • def compare_merge_config(self):

and adding:

  • def merge_config(self, config=None):

Sorry, I went all cleanup mode on ansible/eos_install_config while building the replace in there :)

pyEOS/eos.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn´t we catch the error in the run_commands instead for consistency and reusability?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants