feat: support async methods in ICacheStore#115
Open
therealsujitk wants to merge 2 commits intospotify:mainfrom
Open
feat: support async methods in ICacheStore#115therealsujitk wants to merge 2 commits intospotify:mainfrom
therealsujitk wants to merge 2 commits intospotify:mainfrom
Conversation
Author
|
Hi @jordan-loeser, I've resolved conflicts for this PR, can you take a look at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes - #114
Summary
Added support for writing asynchronous methods in
ICacheStore.Changes
ICacheStorehave been changed to asynchronous methods.ICacheStoreand theICachingStrategyinterfaces still support synchronous return types.SpotifyApi.logout()function however is now asynchronous to supportIAuthStrategy.removeAccessToken()being asynchronous.Results
npm testcommand properly, some test cases failed, I'm hoping someone can help with this. Note that these results are unchanged before and after my changes.