[FIX] auth-module: Refactor ClientCredentialsStrategy constructor and request handling#97
Open
KirtanSoni wants to merge 3 commits intospotify:mainfrom
Open
[FIX] auth-module: Refactor ClientCredentialsStrategy constructor and request handling#97KirtanSoni wants to merge 3 commits intospotify:mainfrom
KirtanSoni wants to merge 3 commits intospotify:mainfrom
Conversation
…egy, its finale request and withClientCredentials method
Remove scope param
KirtanSoni
changed the title
Contributor
|
I merged this change to my fork and released it to npm. I made a small change so that existing code using |
|
Not a member but I thought I'd review this since I was planning to create a PR with these changes. |
|
|
||
| public static withClientCredentials(clientId: string, clientSecret: string, scopes: string[] = [], config?: SdkOptions): SpotifyApi { | ||
| const strategy = new ClientCredentialsStrategy(clientId, clientSecret, scopes); | ||
| public static withClientCredentials(clientId: string, clientSecret: string, config?: SdkOptions): SpotifyApi {//change |
There was a problem hiding this comment.
You'll probably be asked to remove the //change comment from this line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem #95
The ClientCredentialsStrategy constructor included a 'scope' parameter, which was unnecessary and caused inconsistencies. Additionally, the main request in the same class included unnecessary scopes in the request body.
Solution
Refactored the ClientCredentialsStrategy constructor by removing the 'scope' parameter. Modified the main request handling in the same class to exclude unnecessary scopes from the request body. Updated the 'withClientCredentials' static method to align with the changes in the strategy.
Result
The ClientCredentialsStrategy now has a cleaner constructor without the 'scope' parameter, and the main request handling avoids including unnecessary scopes. The 'withClientCredentials' method is consistent with the updated strategy. The README has also been modified to reflect these changes.