This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Created MongoDB template.#26
Open
hekonsek wants to merge 1 commit intospring-attic:masterfrom
hekonsek:mongodb_template
Open
Created MongoDB template.#26hekonsek wants to merge 1 commit intospring-attic:masterfrom hekonsek:mongodb_template
hekonsek wants to merge 1 commit intospring-attic:masterfrom
hekonsek:mongodb_template
Conversation
Contributor
Author
|
Hi Arjen, Any updates on this? Can I do something to push this pull request forward? Cheers. |
|
Hi @hekonsek, Sorry for not getting back to you earlier. The code looks almost ready to merge, I am just missing two things:
Can you add these to the pull request? Or do you want me to do it? Thank you, Arjen |
Contributor
Author
|
Hi Arjen, Of course I'll handle Scaladoc and constructors. Thanks for looking at this PR! Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Arjen,
I created wrapper over Spring Data MongoDB template together with some useful implicit conversions for template callbacks.
I created the tests to cover the most important template methods. I will submit the full test coverage in the near future. I use excellent EmbedMongo library [1] for testing. EmbedMongo is available in Maven central.
I would really appreciating peer review and possible merge of this feature. I would like to include it in a bleeding-edge project for a customer of mine. Early adoption FTW :) .
Cheers.
[1] https://github.com/flapdoodle-oss/embedmongo.flapdoodle.de