fix: Fixed the issue where the returnDirect attribute was not effective on the MCP server side. #3787
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not effective on the MCP server side. Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
… unit tests. Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
|
@sunyuhan1998 Thanks for the quick follow up on this! |
rlagyu0
reviewed
Sep 17, 2025
mcp/common/src/main/java/org/springframework/ai/mcp/SyncMcpToolCallback.java
Show resolved
Hide resolved
rlagyu0
pushed a commit
to rlagyu0/spring-ai
that referenced
this pull request
Sep 17, 2025
…ange false to true Signed-off-by: rlagyu0 <01086055223@hanmail.net>
# Conflicts: # mcp/common/src/main/java/org/springframework/ai/mcp/AsyncMcpToolCallback.java # mcp/common/src/main/java/org/springframework/ai/mcp/McpToolUtils.java # mcp/common/src/main/java/org/springframework/ai/mcp/SyncMcpToolCallback.java # mcp/common/src/test/java/org/springframework/ai/mcp/SyncMcpToolCallbackTests.java
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
|
Will this fix be added to the 1.1.0.M3 pre-release @markpollack ? |
|
Hi @sunyuhan1998 Sorry about the delay in getting to this. Having the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Before this PR, when using the
@Toolannotation to define tools on the MCP server side and specifying thereturnDirectattribute, the attribute would not be properly propagated. As a result, the client was unable to retrieve this information. For a detailed discussion and root cause analysis of this issue, please refer to: #3481 .Thanks to the merge of PR #3781 , we now have the foundation to fix this problem.
Changes in This PR
Preserve the
returnDirectAttributeAdjusted the logic in the
McpToolUtilsclass that constructs tool declarations, ensuring that thereturnDirectattribute from the@Toolannotation is correctly retained and passed through.Implemented
getToolMetadataMethodAdded implementations of the
getToolMetadatamethod in bothAsyncMcpToolCallbackandSyncMcpToolCallbackclasses. This enables clients to retrieve tool metadata, including thereturnDirectflag.Added Unit Tests
Included corresponding unit tests to verify the correctness and stability of the above changes.
Fixes: #3481