Polishing #4605
Merged
Polishing #4605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quaff
commented
Oct 11, 2025
| * @param metadata Document metadata. | ||
| * @return Returns the filtered by configured mode metadata. | ||
| */ | ||
| protected Map<String, Object> metadataFilter(Map<String, Object> metadata, MetadataMode metadataMode) { |
Contributor
Author
There was a problem hiding this comment.
protected modifier is meaningless since the class is final.
quaff
commented
Oct 11, 2025
| private Map<String, Object> metadataFilter(Map<String, Object> metadata, MetadataMode metadataMode) { | ||
|
|
||
| if (metadataMode == MetadataMode.ALL) { | ||
| return new HashMap<>(metadata); |
Contributor
Author
There was a problem hiding this comment.
Creating new HashMap is unnecessary here
ericbottard
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.