test: Enhance PostgresMlEmbeddingOptions test coverage #4674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances test coverage for
PostgresMlEmbeddingOptions
by adding tests for previously untested methods and documenting important builder behavior.Changes
Test Coverage Added
getModel()
andgetDimensions()
return null as designedbuild()
callsValue
The tests reveal that the builder pattern implementation reuses the same options instance rather than creating new instances on each
build()
call. This behavior is now explicitly tested and documented, which is important for developers to understand as it differs from typical builder pattern expectations.