Add a description for a job both with the XML and Java configuration styles #4830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minkukjo
changed the title
- Add description field and methods to AbstractJob class - Implement description setting in JobBuilderHelper - Add test cases for both XML and Java configurations - Update documentation with usage examples Signed-off-by: minkukjo <strike0115@naver.com>
Signed-off-by: minkukjo <strike0115@naver.com>
minkukjo
commented
May 7, 2025
Comment on lines
+23
to
+33
| /** | ||
| * @author Minkuk Jo | ||
| */ | ||
| public class TestTasklet implements Tasklet { | ||
|
|
||
| @Override | ||
| public RepeatStatus execute(StepContribution contribution, ChunkContext chunkContext) { | ||
| return RepeatStatus.FINISHED; | ||
| } | ||
|
|
||
| } No newline at end of file |
There was a problem hiding this comment.
I created this class expecting it to be used globally in my tests, but would it have been better to create it as an inner class in JobXmlDescriptionTests?
Signed-off-by: Harry <43809168+minkukjo@users.noreply.github.com>
|
Hi, @fmbenhassine I hope you're doing well. I just wanted to kindly follow up on my PR Thank you for your time and for maintaining this great project! Best regards, |
Signed-off-by: Harry <43809168+minkukjo@users.noreply.github.com>
# Conflicts: # spring-batch-core/src/test/java/org/springframework/batch/core/job/builder/JobBuilderTests.java
Signed-off-by: minkukjo <strike0115@naver.com>
fmbenhassine
changed the title
|
Thank you for the PR, @minkukjo ! The change set in this PR seems to only add the description to the job , not the step. So I updated the title accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4826
What is the problem
What I Did