Avoid using deprecated Log4j exception converter constructors #46372
+36
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Volkan Yazıcı <volkan@yazi.ci>
vy
force-pushed
the
log4j2-converters-composition
branch
from
18f82d4 to
b14948b
Compare
ppkarwasz
reviewed
Jul 9, 2025
| @@ -34,24 +35,32 @@ | |||
| */ | |||
| @Plugin(name = "ExtendedWhitespaceThrowablePatternConverter", category = PatternConverter.CATEGORY) | |||
| @ConverterKeys({ "xwEx", "xwThrowable", "xwException" }) | |||
| public final class ExtendedWhitespaceThrowablePatternConverter extends ThrowablePatternConverter { | |||
| public final class ExtendedWhitespaceThrowablePatternConverter extends LogEventPatternConverter { | |||
There was a problem hiding this comment.
Nit-pick: Since ExtendedWhitespaceThrowablePatternConverter and WhitespaceThrowablePatternConverter differ only in the specific LogEventPatternConverter they delegate to, the implementation can be simplified by:
- Having one implemented in terms of the other, or
- Taking advantage of the fact that pattern converters don’t need to directly implement
LogEventPatternConverter, but only provide apublic static LogEventPatternConverter newInstance()method, you could have both plugins return the same shared private implementation ofLogEventPatternConverter, reducing duplication.
|
@snicoll, please let us know how you want to proceed with. I've tried to keep the changes minimal, though I can implement the improvements suggested by @ppkarwasz, if it is of your liking. |
snicoll
added
the
for: team-attention
wilkinsona
reviewed
Jul 22, 2025
...c/main/java/org/springframework/boot/logging/log4j2/WhitespaceThrowablePatternConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Volkan Yazıcı <volkan@yazi.ci>
philwebb
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Aug 21, 2025
See gh-46372 Signed-off-by: Volkan Yazıcı <volkan@yazi.ci>
snicoll
added a commit
that referenced
this pull request
Aug 21, 2025
snicoll
changed the title
|
Unfortunately, we need to revert this for now due to apache/logging-log4j2#3893 as warnings caused by the undefined property break our verification tests. |
wilkinsona
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log4j
2.25.0deprecatedThrowablePatternConverterctors, where they are employed in Spring Boot's[Extended]WhitespaceThrowablePatternConverter– see apache/logging-log4j2#3809. This PR amends these classes to avoid using deprecated ctors.