Polish ArchitectureCheckTests #46822
Open
+296
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
force-pushed
the
polish/architecture-rules
branch
6 times, most recently
from
44658b7 to
1fba276
Compare
|
It is highly likely that there will be merge conflicts due to this c211b88 into main, so I prepared the main version for easy merging: main...nosan:architecture-rules-1 |
philwebb
added
type: task
nosan
force-pushed
the
polish/architecture-rules
branch
2 times, most recently
from
8bb381f to
df9a9ab
Compare
Prior to this commit, it wasn't possible to write a test to verify that a specific ArchRule applied only to a specific SourceSet. This PR rewrites `ArchitectureCheckTests` to support different sources and also adds functionality to configure the plugin. With these changes, all tests now verify not only the `checkArchitectureMain` task but also `checkArchitectureTest`. Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
nosan
force-pushed
the
polish/architecture-rules
branch
from
df9a9ab to
baa4270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, it's not possible to write a test to verify that a specific rule applies only to a specific
SourceSet.This PR rewrites
ArchitectureCheckTeststo support different sources and additionally adds functionality to configureprohibitObjectsRequireNonNullas well.Additionally, with these changes, all tests will verify not only the checkArchitectureMain task but also checkArchitectureTest.