Skip to content

Conversation

@vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 18, 2025

Closes gh-39539

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 18, 2025
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that it is a good idea to link to official materials rather than explaining third-party features in our own doc, I find the change a bit rough. If you understand liquibase, as well as how to use it in Spring Boot, then you can patch things up and understand how to use it.

However, for a newcomer, you need to map what's described in the liquibase doc to what you'd do in a Spring Boot app (if you wish to). Have you considered keeping the SB-related bits as short as possible and then refer to the doc + blog posts?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Nov 18, 2025
@vpavic
Copy link
Contributor Author

vpavic commented Nov 18, 2025

If you understand liquibase, as well as how to use it in Spring Boot...

I would expect this to be the case, because if you're seeking guidance about test-only migrations using a specific library for DB migration, it means you already know how to use it in Spring Boot?

But I do understand that this PR replaces a lot of something with some fairly minimal content consisting of external references. I'll take a look tomorrow into what would be a minimal example of connecting the dots between those external references and something that would be a domain of Spring Boot based application.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 18, 2025
@snicoll
Copy link
Member

snicoll commented Nov 19, 2025

it means you already know how to use it in Spring Boot?

I suppose so but assumptions like that are a bad idea. We need to strike a good balance between repeating ourselves and guiding users to link external content and how it can be used by the project.

a minimal example of connecting the dots between those external references and something that would be a domain of Spring Boot based application.

That's exactly what I am asking, so thanks for that!

@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Nov 19, 2025
@snicoll snicoll added this to the 3.5.x milestone Nov 19, 2025
@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Nov 19, 2025
…manual

Closes spring-projectsgh-39539

Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
@vpavic
Copy link
Contributor Author

vpavic commented Nov 20, 2025

I've added something that should qualify as a minimal example of connecting the dots between those external references and something that would be a domain of Spring Boot based application.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 20, 2025
@snicoll snicoll removed the status: feedback-provided Feedback has been provided label Nov 21, 2025
snicoll pushed a commit that referenced this pull request Nov 21, 2025
See gh-48169

Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
@snicoll snicoll closed this in d4408ab Nov 21, 2025
@snicoll snicoll modified the milestones: 3.5.x, 3.5.9 Nov 21, 2025
@snicoll
Copy link
Member

snicoll commented Nov 21, 2025

Thanks @vpavic.

@vpavic vpavic deleted the gh-39539 branch November 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants