Skip to content

Refactor type checks and improve code readability #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Refactor type checks and improve code readability #3580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0872d25
Replace Collection.class.isInstance with instanceof for type checking
Seol-JY Aug 14, 2024
22762d9
Remove unnecessary type check for ConfigurableListableBeanFactory in …
Seol-JY Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public void registerBeansForRoot(BeanDefinitionRegistry registry, RepositoryConf

registerIfNotAlreadyRegistered(() -> {

Object value = AnnotationRepositoryConfigurationSource.class.isInstance(config) //
Object value = config instanceof AnnotationRepositoryConfigurationSource //
? config.getRequiredAttribute(ESCAPE_CHARACTER_PROPERTY, Character.class) //
: config.getAttribute(ESCAPE_CHARACTER_PROPERTY).orElse("\\");

Expand Down
8 changes: 1 addition & 7 deletions ...mework/data/jpa/repository/support/EntityManagerBeanDefinitionRegistrarPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,7 @@ public int getOrder() {
@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {

if (!ConfigurableListableBeanFactory.class.isInstance(beanFactory)) {
return;
}

ConfigurableListableBeanFactory factory = beanFactory;

for (EntityManagerFactoryBeanDefinition definition : getEntityManagerFactoryBeanDefinitions(factory)) {
for (EntityManagerFactoryBeanDefinition definition : getEntityManagerFactoryBeanDefinitions(beanFactory)) {

BeanFactory definitionFactory = definition.getBeanFactory();

Expand Down
2 changes: 1 addition & 1 deletion ...pa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ public void deleteAllByIdInBatch(Iterable<ID> ids) {
* Some JPA providers require {@code ids} to be a {@link Collection} so we must convert if it's not already.
*/

if (Collection.class.isInstance(ids)) {
if (ids instanceof Collection) {
query.setParameter("ids", ids);
} else {
Collection<ID> idsCollection = StreamSupport.stream(ids.spliterator(), false)
Expand Down
Loading