Skip to content

MockMvcRequestConverter uses US_ASCII for URL decoding while encoding uses UTF-8 #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
config25 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

MockMvcRequestConverter uses US_ASCII for URL decoding while encoding uses UTF-8 #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aed94c2
Fix URL decoding charset mismatch in MockMvcRequestConverter
config25 Mar 31, 2026
fbf7cba
Replace non-ASCII tests with one that exercises decode()
config25 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s-mockmvc/src/main/java/org/springframework/restdocs/mockmvc/MockMvcRequestConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ private static void processParameter(String parameter, MultiValueMap<String, Str
}

private static String decode(String encoded) {
return URLDecoder.decode(encoded, StandardCharsets.US_ASCII);
return URLDecoder.decode(encoded, StandardCharsets.UTF_8);
}

}
13 changes: 13 additions & 0 deletions ...kmvc/src/test/java/org/springframework/restdocs/mockmvc/MockMvcRequestConverterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,19 @@ void postRequestWithParametersAndQueryStringCreatesFormUrlEncodedContentWithoutD
assertThat(request.getHeaders().getContentType()).isEqualTo(MediaType.APPLICATION_FORM_URLENCODED);
}

@Test
void postRequestWithNonAsciiParametersAndQueryStringCreatesFormUrlEncodedContentWithoutDuplication() {
OperationRequest request = createOperationRequest(MockMvcRequestBuilders
.post("/foo?name=%ED%99%8D%EA%B8%B8%EB%8F%99")
.param("name", "\uD64D\uAE38\uB3D9")
.param("other", "\uD64D\uAE38\uB3D9"));
assertThat(request.getUri())
.isEqualTo(URI.create("http://localhost/foo?name=%ED%99%8D%EA%B8%B8%EB%8F%99"));
assertThat(request.getMethod()).isEqualTo(HttpMethod.POST);
assertThat(request.getContentAsString()).isEqualTo("other=%ED%99%8D%EA%B8%B8%EB%8F%99");
assertThat(request.getHeaders().getContentType()).isEqualTo(MediaType.APPLICATION_FORM_URLENCODED);
}

@Test
void mockMultipartFileUpload() {
OperationRequest request = createOperationRequest(MockMvcRequestBuilders.multipart("/foo")
Expand Down