Fix proxy attribute name mismatch in RetryOperationsInterceptor#490
Conversation
|
ok，亲~~~
|
|
您好，我已经收到您的邮件，将尽快给您回复。
|
junhyeongkim2
force-pushed
the
fix-proxy-attribute-mismatch
branch
from
d1c2a7c to
57f5480
Compare
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Please, consider to use your legal name for Git client.
That Signed-off-by: junhyeongkim2 <ggprgrkjh@naver.com> is not a official name and we cannot accept such a contribution.
See more about DCO: https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin
junhyeongkim2
force-pushed
the
fix-proxy-attribute-mismatch
branch
from
57f5480 to
0bb8e1a
Compare
|
I've updated the DCO signature with my legal name as requested. Thank you for your guidance! |
Signed-off-by: Kim Jun Hyeong <ggprgrkjh@naver.com>
junhyeongkim2
force-pushed
the
fix-proxy-attribute-mismatch
branch
from
0bb8e1a to
44dd551
Compare
|
I've removed the duplicate DCO signatures and kept only my legal name version. The issue is now resolved. |
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
I wonder if that would be possible to cover your fix with some unit test.
Apparently we don't have one since this was wrong there for years.
Thanks
|
I appreciate the opportunity. I'll create a unit test for this fix and send it over for review. |
Signed-off-by: Kim Jun Hyeong <ggprgrkjh@naver.com>
Signed-off-by: Kim Jun Hyeong <ggprgrkjh@naver.com>
junhyeongkim2
force-pushed
the
fix-proxy-attribute-mismatch
branch
from
deb7c99 to
606eacc
Compare
|
Added tests for RetryOperationsInterceptor's proxy attribute cleanup: Verifies correct removal with proper key (" _ _ _ proxy _ _ _ ") I’m still learning, so I’d really appreciate any feedback or suggestions. thanks! |
Signed-off-by: Kim Jun Hyeong <ggprgrkjh@naver.com>
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Please, also update Copyright of the affected classes to current 2025.
Thanks
| RetrySynchronizationManager.register(context); | ||
| context.setAttribute("___proxy___", mockProxy); | ||
| assertThat(context.getAttribute("___proxy___")).isNotNull(); | ||
| assertThatIllegalStateException().isThrownBy(() -> this.interceptor.invoke(new MethodInvocation() { |
There was a problem hiding this comment.
Please, consider to extract a MethodInvocation into a variable before this assertion.
After that the assertion sentence would be much easier to read.
I also don't see a reason to have the whole interface implementation.
We probably can simply use a mock() and then stub that getMethod().
There was a problem hiding this comment.
Thank you for your feedback! I’ve applied all of your suggestions. Please let me know if you’d like any further adjustments.
…lify mocking Signed-off-by: Kim Jun Hyeong <ggprgrkjh@naver.com>
junhyeongkim2
force-pushed
the
fix-proxy-attribute-mismatch
branch
from
c93e9e6 to
be5bc04
Compare
|
thank you very much for the contribution; looking forward for more! |
4 participants
Found a small bug: I might be mistaken, but I think the proxy key mismatch is preventing removal. Please have your team take a look when you have a moment. Thanks!