Skip to content

Conversation

@BoykoAlex
Copy link
Contributor

@BoykoAlex BoykoAlex commented Nov 3, 2025

Fixes #1631

  • DocSymbol. Do not create a doc symbol for something without the name
  • Account for comments while parsing. Treat comment starting with #@ as YTT comment and disable validation for a node with YTT comments

SnakeYAML parser would think that comment placed before an empty value hence a few unit test adjustments.

Signed-off-by: BoykoAlex <alex.boyko@broadcom.com>
Signed-off-by: BoykoAlex <alex.boyko@broadcom.com>
Signed-off-by: BoykoAlex <alex.boyko@broadcom.com>
Signed-off-by: BoykoAlex <alex.boyko@broadcom.com>
@kdvolder
Copy link
Member

kdvolder commented Nov 5, 2025

LGTM

@BoykoAlex BoykoAlex marked this pull request as ready for review November 5, 2025 18:55
@BoykoAlex BoykoAlex merged commit 156cf92 into main Nov 5, 2025
4 checks passed
@BoykoAlex BoykoAlex deleted the ytt branch November 5, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Concourse] does not handle ytt syntax well

3 participants