Configurable max attempt | Failed flag | Bugfix for queue#7
Open
hoekstramenno wants to merge 3 commits intospringbot:masterfrom
hoekstramenno:ConfigurableMaxAttempt
Open
Configurable max attempt | Failed flag | Bugfix for queue#7hoekstramenno wants to merge 3 commits intospringbot:masterfrom hoekstramenno:ConfigurableMaxAttempt
hoekstramenno wants to merge 3 commits intospringbot:masterfrom
hoekstramenno:ConfigurableMaxAttempt
Conversation
added 3 commits
August 21, 2017 12:29
…k when the job was failed
…date 'failed' with the current time
…s job with the same class/method was failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First the table is updated with a new 'datetime' column called 'failed'. This one is showing the date when the job hits the maximum. This is useful for debugging and/or making queries.
The max attempts was hardcoded in the query. It is now a configurable value. If the max attempts is reached, update the failed column with the current datetime.
Bugfix: when a job is failed (max attempts is reached) it was not possible to add the same class/method.