G3 upgrade #23
Open
G3 upgrade #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he documentation plugin bootstrap from starting until Grails has started. This resolves the issue with the GORM startup exception
|
wwwwaaat! this is awesome! thank you so much for taking time to look at the upgrade path. 🤘 I'll review and merge |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dilipkrish I have went through and got the project working with Grails 3.3.2. This update gets the dependencies and imports updated correctly. The other major change made is to have the DocumentationPluginsBootstrapper not startup with the Spring context but with the Grails Application through the SwaggerGrailsApplicationPostProcessor.onStartup method. This is similar to the way Springs SmartLifecycle interface works but in the context of Grails lifecycle.
I saw the changes in the issue/18 branch but didn't have time to integrate all the changes. I figure this is a release that could be put out sooner to get basic Grails 3.3.X support working. I believe it will be compatible with any Grails 3.X version as well, so backwards compatible, but I haven't fully confirmed that.