Open
Conversation
chrishalbert
left a comment
chrishalbert
left a comment
There was a problem hiding this comment.
I know its just a work in progress, but figured I'd add a few notes.
| # You need to fill in the domain of where you install | ||
| # Botanist for this to work, obviously :) | ||
| BOTANIST_DOMAIN = 'http://example.com' | ||
| BOTANIST_DOMAIN = 'https://codesearcher.int.sproutsocial.com/' |
There was a problem hiding this comment.
It may be worth force pushing to remove that internal domain from this public pull request - not that it's accessible outside your network, but if someone gets on the network, they'd know where to go
| BOTANIST_DOMAIN = 'https://codesearcher.int.sproutsocial.com/' | ||
| # NOTE: Fill out with real username/password to test. | ||
| # (Or come up with a real solution like sticking an auth-less version behind SDM) | ||
| LDAP_USERNAME = '' |
There was a problem hiding this comment.
Maybe put these variables in the .env.template and that way you can save your LDAP_USERNAME and LDAP_PASSWORD to the .env.local so that there's no chance of an accidental commit...but what could be really fun is integrating it with your SSO provider 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some breadcrumbs if/when we want to pick this up...
The changes below makes it so
btgrep.pycan make authenticated calls to our prod codesearcher domain.The resulting request looks like e.g. https://codesearcher.int.sproutsocial.com/search/results.json?q=foobar&case=sensitive, and is a 500. It looks easy enough to fix (just follow link for stack trace). But I ran into problems running the app locally, either using Docker or running Django directly (with a 2.7 virtualenv...).