fix: resolve state management bug and add test coverageFix/bug1 state management#4
Open
ChuhengYu22 wants to merge 8 commits intosptin2002:mainfrom
Open
fix: resolve state management bug and add test coverageFix/bug1 state management#4ChuhengYu22 wants to merge 8 commits intosptin2002:mainfrom
ChuhengYu22 wants to merge 8 commits intosptin2002:mainfrom
Conversation
…e/Lighthouse critical issue) Fixes the accessibility issue where form elements (#services-list, #service-name, #service-price) lacked associated labels. Modified index.html by adding explicit <label> elements with for attributes. This addresses the "Form elements must have labels" and "Select element must have an accessible name" violations detected by axe DevTools.
Defect 1: Add accessible labels for select and input elements (axe/Lighthouse critical issue)
…sector price inputs
Fix sector price inputs:
- Replace invalid id `price-[object Object]` with `price-{sectorName}`
- Add explicit `<label>` for each input to meet WCAG 4.1.2
Now all dynamically generated form controls have proper accessible names.
Fix: Add accessible labels and correct IDs for dynamically generated sector price inputs
Add <main> tag as the main landmark to improve screen reader navigation and comply with Lighthouse best practices. This change replaces the outer <div id="seat-booking-app"> with <main id="seat-booking-app"> and updates the closing tag accordingly. No functional changes.
Improve Lighthouse best practices score by adding main landmark
…ug, clear reserved seats on service change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files Changed
Test Coverage