This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Open
Conversation
sqjin
approved these changes
May 20, 2021
sqjin
reviewed
May 20, 2021
| } | ||
|
|
||
| prob <- prob[,,pairLR.name.use] | ||
| prob <- prob[,,pairLR.name.use, drop=FALSE] |
Owner
There was a problem hiding this comment.
This is not necessary as we have if (length(dim(prob)) == 2) below.
sqjin
reviewed
May 20, 2021
R/modeling.R
Outdated
| prob.pathways.sig <- prob.pathways[,,pathways.sig, drop=FALSE] | ||
| idx <- sort(apply(prob.pathways.sig, 3, sum), decreasing=TRUE, index.return = TRUE)$ix | ||
| pathways.sig <- pathways.sig[idx] | ||
| prob.pathways.sig <- prob.pathways.sig[, , idx] |
Owner
There was a problem hiding this comment.
Can you also change line 381 prob.pathways.sig <- prob.pathways.sig[, , idx] to prob.pathways.sig <- prob.pathways.sig[, , idx, drop=FALSE]
Owner
|
@stemangiola Thanks for your contribution. I made two comments. Can you please edit them and then I will merge these pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my dataset, the third dimension is 1, so drop=F avoids software crash.
Could you also please advise whether this is sometimes expected?