Open
Conversation
Various fixes to avoid build complaints about mixed signedness in comparisons (as from g++'s -Wsign-compare), mostly between int and size_t.
Update a few comparisons that use bitwise operators (&, |), where logical operators (&&, ||) seem intended instead.
SurvivalForest Data implementation's get() and getIndex() functions can terminate without returning a defined value. It's not clear what should be returned in the undefined code path so throw an exception instead.
hartb
added a commit
to hartb/powerai
that referenced
this pull request
Apr 27, 2020
Add feedstock for pysurvival, an open source package for Survival Analysis modeling. See: - https://www.pysurvival.io/ - https://github.com/square/pysurvival Include several local fixes, including some that should improve correctness. See: square/pysurvival#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR quiets some build warnings from g++.
It includes a couple commits that are unlikely to affect correctness:
quiet signedness comparison build warnings - adjust some
int/size_ttyping to avoid comparisons of different signedness
remove some unused variables
It also includes a couple changes that will likely improve correctness (it
would be good to get additional review of these):
fix some logical vs bitwise operator cases - fix tests in some
ifandwhilestatements that were using bitwise operators (&,|) whereprobably the logical operators (
&&,||) were intendedavoid undefined behavior in SurvivalForest Data get() and getIndex() - these
could reach end of function without an explicit return, resulting in
undefined behavior. Appropriate return value not clear in those cases, so
raise an exception.
A couple remaining build warnings are not addressed by this PR:
a few more
intvssize_tsignedness comparison complaints fromcython-generated code. These would require only minor changes to
_coxpy.pyxand_svm.pyx, and regeneration of thecppfiles withcython. Regenerating with current cython generates very large diffs
so those changes are not included here.
complaints about use of deprecated numpy APIs when building the
cython-generated sources. Didn't investigate whether this would require
any
pyxcode changes or just regeneration with current cython.