This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Split transfer data because of the size limit of FileChannelImpl#216
Open
wecharyu wants to merge 1 commit intosquare:masterfrom
Open
Split transfer data because of the size limit of FileChannelImpl#216wecharyu wants to merge 1 commit intosquare:masterfrom
wecharyu wants to merge 1 commit intosquare:masterfrom
Conversation
Collaborator
|
Change looks good. I need to update our CI which I can't do until next week. After that I'll rebase your changes to ensure they pass and merge. |
Author
|
Gentle Ping @JakeWharton, btw do we need to release a new version for this fix? |
Collaborator
|
Forgot about it. I'll try again next week. |
Author
|
Hi @JakeWharton please try this PR this week. Thanks a lot :) |
Collaborator
|
I have some other work and then I'm going on vacation. Earliest I'll get to this library is in September. |
Author
|
OHOK thank you, have a good vacation~ |
|
Hey @JakeWharton just a re-ping, maybe this got lost in the shuffle... |
Author
|
Hi @JakeWharton, please help check this PR at your convenience. |
|
Yearly re-ping? Or close the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Integer.MAX_VALUEWhy needs these changes
In the underlying
FileChannelImpl, it can transfer at most 2 GB data at a time, which will cause an error if we transfer more than 2 GB data directly:tape/tape/src/main/java/com/squareup/tape2/QueueFile.java
Lines 462 to 464 in 445cd3f