-
Notifications
You must be signed in to change notification settings - Fork 14
fix: updating web-sdk-types version #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| }, | ||
| "dependencies": { | ||
| "@square/web-payments-sdk-types": "^1.79.0" | ||
| "@square/web-payments-sdk-types": "^1.81.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to do this manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package uses npm/npx based package controls, rather than the yarn + yarn upgrade-interactive that we are used to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We normally see types version updates as dependabot PRs. In fact, I see one open right now (PR #503)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to test our new NPM key, by prompting the release of a new package version. According to the runbooks, the best way to do this is with a fix pr (ex. here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, makes sense.
Update the WebSDK Types Package version