Make the bindService method final
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clamothebb
changed the title
bindService method final to be consistent with gRPC-javabindService method final
Member
|
@jvmakine can you have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your amazing work on Wire.
I noticed an inconsistency between gRPC-java and Wire's output that, if resolved, enables Wire to be integrated with tools that expect gRPC-java's output.
Since 2016, grpc-java's generated
bindServicemethod has beenfinal. See the grpc-java issue for related discussion.Making wire's generated code consistent with this makes it compatible with related tooling that depends on this, such as gRPC-Spring's support for Spring's method security.