Conversation
added cmake to the stl_reader project for ease of inclusion in other projects [WIP]
Owner
|
Hi Jeff, thanks a lot for creating those scripts and putting the pull request up. Really appreciated! Thanks and best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for putting this
stl_readertogether! It is working great for my needs.Although this project is already quite simple to consume, a lot of people prefer to consume all of the dependencies through
cmake. I restructured things slightly to put the header file underinclude/stl_reader, and added aCMakeLists.txt. This way, thestl_readercan be packaged using the usualThis project can then be included in their other project's
CMakeLists.txtfile using:And the header file will be available using
#include <stl_reader/stl_reader.h>in any file of the consumer.