Skip to content

Conversation

ARMS2025
Copy link

I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that

In the test testScriptUrlConfiguration:

  • The executeScript method for the javascriptExecutor object:
    i) during test execution the method is actually called with argument URL_CONFIGURATION_TEST_SCRIPT, but is not stubbed, resulting in a mismatch stubbing (as the argument is a lengthy string, we extracted it into a private static variable and used that variable in the stub creation).

In the test testExecute:

  • The executeScript method for the javascriptExecutor object:
    i) during test execution the method is actually called with argument EXECUTE_TEST_SCRIPT, but is not stubbed, resulting in a mismatch stubbing (as the argument is a lengthy string, we extracted it into a private static variable and used that variable in the stub creation).

In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).

I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.

@sridharbandi
Copy link
Owner

@ARMS2025 Thanks for this PR. Apart from the tests, do you have faced any issues while using this library?

@ARMS2025
Copy link
Author

@sridharbandi No, I did not face any other issues while using the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants