Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…mplate Signed-off-by: Sricharan Reddy Varra <sricharanvarra@gmail.com>
Signed-off-by: Sricharan Reddy Varra <sricharanvarra@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
===========================================
- Coverage 98.13% 49.68% -48.45%
===========================================
Files 13 13
Lines 322 322
===========================================
- Hits 316 160 -156
- Misses 6 162 +156 |
Signed-off-by: Sricharan Reddy Varra <sricharanvarra@gmail.com>
|
@greptile |
Greptile Overview
|
| Filename | Overview |
|---|---|
| pyproject.toml | Migrated to dependency groups (PEP 735), bumped Python minimum to 3.11, updated narwhals to 2.14+, consolidated ruff config from external file |
| src/annsel/core/utils.py | Replaced inspect-based expression parsing with narwhals private API _expression_parsing. Known limitation: doesn't handle nested expressions correctly |
| src/annsel/tl/_filter.py | Changed truthiness checks to explicit is not None checks for better handling of empty/falsy values |
| src/annsel/tl/_select.py | Changed truthiness checks to explicit is not None checks for better handling of empty/falsy values |
| .github/workflows/test.yaml | Complete rewrite to use hatch test matrix from pyproject.toml, tests only 3.11 and 3.14 (stable), 3.14 (pre-release), added all-green check job |
| .github/workflows/build.yaml | Simplified to check package build validity using twine, removed artifact upload and workflow dependencies |
Last reviewed commit: ceacb2e
Signed-off-by: Sricharan Reddy Varra <sricharanvarra@gmail.com>
Signed-off-by: Sricharan Reddy Varra <sricharanvarra@gmail.com>
Greptile Overview
|
| Filename | Overview |
|---|---|
| pyproject.toml | Critical issue: Migrated to dependency groups and hatch test matrix (3.11, 3.14), but missing required hatch-test scripts (run-cov, cov-combine, cov-report) that CI workflow expects |
| .github/workflows/test.yaml | Refactored to use dynamic hatch environment discovery, but references undefined hatch scripts that will cause CI failures |
| .github/workflows/build.yaml | Simplified to single-job package build check with twine validation, removed matrix strategy |
| .pre-commit-config.yaml | Updated ruff hook from 'ruff' to 'ruff-check' and excluded .cruft.json from biome-format |
| .readthedocs.yaml | Restructured to use hatch for docs build, updated to Ubuntu 24.04 and Python 3.13 |
Last reviewed commit: 5e7f4e9
| [tool.hatch.envs.hatch-test] | ||
| dependency-groups = [ "dev", "test" ] |
There was a problem hiding this comment.
Missing required hatch scripts. The CI workflow (.github/workflows/test.yaml:78-84) references run-cov, cov-combine, and cov-report scripts, but these aren't defined here.
Add after line 93:
| [tool.hatch.envs.hatch-test] | |
| dependency-groups = [ "dev", "test" ] | |
| dependency-groups = [ "dev", "test" ] | |
| [tool.hatch.envs.hatch-test.scripts] | |
| run = "pytest {args}" | |
| run-cov = "pytest --cov --cov-report=term-missing {args}" | |
| cov-combine = "coverage combine" | |
| cov-report = "coverage report" |
cookiecutter-scversereleased v0.7.0.Changes
Changes
@flying-sheepin Switch to dependency groups scverse/cookiecutter-scverse#449@Zethsonin Use type instead of label for issue templates scverse/cookiecutter-scverse#444@flying-sheepin chore: use KaTeX Sphinx plugin scverse/cookiecutter-scverse#446Fixes
@ilia-katsin sphinx conf.py: use project instead of project_name scverse/cookiecutter-scverse#440@flying-sheepin Fix workflow badge and link in readme scverse/cookiecutter-scverse#441@grstin Enable OIDC in Codecov action scverse/cookiecutter-scverse#457Additional remarks
add
skip: truetotemplate-repos.ymlusing a PR or,if you never want to sync from the template again, delete the
.cruft.jsonfile in the root of your repository.Make sure to activate those apps if you haven't already.