Separate model checksum and finalise #1
+74
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All looks fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Created (into my fork main..) for demonstration purposes as I have been going through old SRS tickets. If this is reasonable I create a full PR in the next release cycle.
This is a small followup refactor that I suggested in: https://code.metoffice.gov.uk/trac/lfric/ticket/4351. It separates the finalization and checksum of the model. The motivation here is for slightly cleaner interface as the checksum is only needed with running the full model and is not needed in the integration tests and JEDI.
The current solution is the inclusion of an optional that does the checksum if it is present. Here the checksum is explicitly called.
Happy to leave as is and close this PR and the ticket or progress the update in the next release. What do you think @thomasmelvin @cjohnson-pi