RHEL-8 workflow nad dockerfiles, using AlmaLinux#4
Open
sshi-amd wants to merge 13 commits intoamd-stagingfrom
Open
RHEL-8 workflow nad dockerfiles, using AlmaLinux#4sshi-amd wants to merge 13 commits intoamd-stagingfrom
sshi-amd wants to merge 13 commits intoamd-stagingfrom
Conversation
sshi-amd
force-pushed
the
RHEL-8-workflows
branch
from
bb3a7b4 to
61a0054
Compare
…s option to not build any rocdecode tests
* Sync rocDecode with upstream for TheRock support Signed-off-by: zichguan-amd <zichuan.guan@amd.com> * Return 1 for rocDecode unsupported codec Signed-off-by: zichguan-amd <zichuan.guan@amd.com> * Skip rocDecode FFmpeg tests on gfx1151 Signed-off-by: zichguan-amd <zichuan.guan@amd.com> --------- Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
The RHEL-8 Dockerfile was missing FFmpeg, which was added to SLES and Ubuntu in cdb90e5 but not RHEL-8. This caused the rocDecode examples that require FFmpeg (find_package(FFmpeg REQUIRED)) to fail during CMake build. Also fixes a syntax error in the Ubuntu Dockerfile where a missing '&&' caused 'apt-get clean' to be parsed as package names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Vulkan SDK's prebuilt glslangValidator requires glibc 2.34+, but RHEL 8 only has glibc 2.28. The Dockerfile already built glslang from source to /usr/local/bin/, but CMake's FindVulkan uses the VULKAN_SDK env var (not PATH) to locate glslangValidator, so it always found the incompatible prebuilt binary. Fixes: - Overwrite the prebuilt glslangValidator in the Vulkan SDK directory with the source-built one in the Dockerfile - Add a runtime workaround in the reusable workflow that copies the source-built binary into the SDK dir (works with the current image before the Dockerfile is rebuilt) - Add libatomic package (required by ROCm SDK shared libraries) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Both targets use std::thread but were missing find_package(Threads) and Threads::Threads linkage, causing undefined symbol pthread_create on RHEL 8 where the linker requires explicit pthread linkage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cherry-picked from upstream ROCm/rocm-examples@4a0b4be1. Fixes p2p example error when p2p not supported, fixes type cast warnings, and adds -lpthread to rocProfiler-SDK Makefiles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cherry-picked from upstream ROCm/rocm-examples@51c78864. Improves test failure reporting in CI summary and uploads test logs as artifacts for debugging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist