Open
Conversation
NHOrus
added a commit
to NHOrus/gentoo
that referenced
this pull request
Feb 10, 2026
Patch to make this valid C23 is too large, see also: sshlien/abcmidi#15 for start of the port. Unfeasible to carry in-tree. Closes: https://bugs.gentoo.org/968775 Closes: https://bugs.gentoo.org/943863 Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
4 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Feb 11, 2026
Patch to make this valid C23 is too large, see also: sshlien/abcmidi#15 for start of the port. Unfeasible to carry in-tree. Closes: https://bugs.gentoo.org/968775 Closes: https://bugs.gentoo.org/943863 Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com> Part-of: #45728 Closes: #45728 Signed-off-by: Sam James <sam@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #14 I converted the function declarations in mixed (K&R and ANSI) mode to plain ANSI. Next steps would be to reduce remaining warnings, then remove duplicate code.
The changes need to be reviewed carefully!
There is an ambiguity concerning
chanpressure(). For the different tools there are two versions, one with two and one with three parameters. Needs to be checked if I harmonized that correctly.