You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, I want to thank you for putting the effort into this.
That said, I have two concerns:
Now that I'm working on QuickTile again, coming up with a general solution for customizing cycling behaviour is a high priority.
I anticipate this mechanism existing for only a short period of time and, because I try to maintain backwards compatibility for configuration files, it would leave behind added complexity for the config migration code effectively forever, despite existing for such a short period. (and I still need to get around to going back through old versions and generating a bunch of test files to ensure the migrations actually work.)
My first goal is to finish refactoring the code and de-snarling __main__.py is likely going to be my next target. If I haven't merged this first, the PR will break.
(In short, this is a textbook example of why the developer's guide asks people to open feature requests before pull requests so we can coordinate on things before effort is put in.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration option to select the order in which the window positions are cycled.
Perhaps more consideration should be given to the options available. But I have added only 2:
default, which is selected by default and which cycles positions in the previous order, andsmall_first, which starts with the smallest position first.