Add command to goto certain position#133
Open
Matthijsy wants to merge 1 commit intossokolow:masterfrom
Open
Conversation
Owner
|
Sorry for taking so long to respond. I'm a bit busy jugging a few things right now, so I haven't had time to look at the PR, but I'll leave this tab open as a reminder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new command to goto a certain grid position, without cycling through the different dimensions. For example if you want to have a screen on the left 1/3 you have to run the left command twice. However with this new command you can run
goto-1/3-1. If you want to have the 2/3 you currently have to run the left command 3 times, now you can dogoto-2/3-1. If you want it in the upper 2/3 in the right corner you can rungoto-2/3-2-top.The code does automatically adapt to the amount of columns that are defined. Some of the commands might be duplicate (like goto-2/4-1 and goto-1/2-1 are the same), but that is not an issue I suspect.
Would really love to receive some feedback on this idea