Skip to content

Merge beginnings of a functional test suite into PyTest runs#147

Merged
ssokolow merged 12 commits intomasterfrom
devel
Sep 7, 2025
Merged

Merge beginnings of a functional test suite into PyTest runs#147
ssokolow merged 12 commits intomasterfrom
devel

Conversation

@ssokolow
Copy link
Owner

@ssokolow ssokolow commented Sep 7, 2025

  1. Fix "do any commands crash?" functional test suite so it waits for WM properly
  2. Merge functional suite in under PyTest
  3. Fix some stale instructions in the developer's guide
  4. Add pytest-xvfb, Xvfb, Openbox, and Zenity as CI dependencies
  5. Fix an oversight in run_tests.sh

(To truly do it properly, after retrieving the window ID from
_NET_SUPPORTING_WM_CHECK, it needs to check that the window exists...
but given the scenario, that feels like YAGNI.)
(Currently, `zenity --info` is used to provide the target window)
@ssokolow ssokolow marked this pull request as draft September 7, 2025 05:30
@ssokolow
Copy link
Owner Author

ssokolow commented Sep 7, 2025

To anyone who sees this, I'm probably going to stop for the evening.

Figuring out why Xvfb is working locally but not on GitHub Actions is a job for a less tired mind.

(Since I'd been overlooking broken/unimplemented Zaphod-mode support
anyway, so I might as well just ditch tests which rely on it.)
@coveralls
Copy link

coveralls commented Sep 7, 2025

Coverage Status

coverage: 80.265% (+15.8%) from 64.422%
when pulling 87d7200 on devel
into b0c6e46 on master.

@ssokolow ssokolow marked this pull request as ready for review September 7, 2025 12:04
@ssokolow ssokolow merged commit 2c499be into master Sep 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants