p5 Brush Assignment: Code Review#1
Open
aaga wants to merge 2 commits intoteachingteamfrom
Open
Conversation
aaga
commented
Jul 7, 2021
Collaborator
Author
aaga
left a comment
aaga
left a comment
There was a problem hiding this comment.
Nice brush with a cool background image feature. good variable names; could use a little bit more commenting to explain some parts of the code. Overall, great job!
| Heat, heat waves, I'm swimmin' in a mirror | ||
| Road shimmer wigglin' the vision | ||
| Heat, heat waves, I'm swimmin' in a— | ||
| (Moo, moo, moo, moo, moo, moo, moo, mooooo) |
| @@ -1,11 +1,66 @@ | |||
| // let lyrics; | |||
Collaborator
Author
There was a problem hiding this comment.
you can remove commented code when you're no longer using it!
Collaborator
Author
There was a problem hiding this comment.
just keeps things a bit tidy
| stroke_color = color('pink'); | ||
| fill_color = color('black'); | ||
|
|
||
| linesList.forEach((line) => { |
Collaborator
Author
There was a problem hiding this comment.
good use of the arrow function
| function draw() { | ||
| } | ||
|
|
||
| let fill_color = backgroundImg.get(mouseX, mouseY); |
| let linesList = []; | ||
| let wordsList = []; | ||
| let stroke_color; | ||
| let fill_color; |
Collaborator
Author
There was a problem hiding this comment.
you don't need fill_color here since you recalculate every frame in the draw function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice brush! see comments below