Conversation
Move nickname reverse index logic into dedicated service class for better separation of concerns. SharedAddressData now delegates to the service via thin wrapper methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Store and restore the original header line from CDV files instead of reconstructing it. This ensures any metadata in the header is preserved through load/save cycles. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move file monitoring logic into dedicated FileMonitor class for better separation of concerns. SharedAddressData now owns a FileMonitor instance and delegates via thin wrapper methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move file monitoring logic into dedicated FileMonitor class for better separation of concerns. SharedAddressData now owns a FileMonitor instance and delegates via thin wrapper methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Step 3a: Consolidated paired type constants to models/constants.py - Added INTERLEAVED_TYPE_PAIRS and INTERLEAVED_PAIRS as canonical sources - Deleted PAIRED_BLOCK_TYPES from blocktag.py - Updated dependency_service.py and dataview_editor/window.py to import from constants Step 3b: Moved multi-row block logic from blocktag.py to block_service.py - find_paired_tag_index() - Find matching open/close tag - find_block_range_indices() - Get (start, end) range - compute_all_block_ranges() - Compute all block ranges - validate_block_span() - Validate block doesn't cross memory types - blocktag.py now contains only single-comment parsing operations Step 3c: Deleted duplicate find_paired_row implementations - Removed unused BlockService.find_interleaved_pair_idx() - Kept RowDependencyService.find_paired_row() (efficient addr_key lookup) - Kept view_builder.find_paired_row() (already uses constants) Step 3d: Renamed for clarity - auto_update_paired_tag() -> auto_update_matching_block_tag() - Clarifies it handles open/close tag pairing, not T/TD type pairing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Verify that CDV headers with column widths (e.g., 0,0,0,559,653,...) are preserved correctly during save/load round-trips. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extractions:
Consolidation:
Feature:
Impact